feat: add ignore tag images option #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitagry
force-pushed
the
ignore-tag-names
branch
from
bd36262
to
22a84c9
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 70.07% 71.37% +1.29%
==========================================
Files 7 7
Lines 665 758 +93
==========================================
+ Hits 466 541 +75
- Misses 199 217 +18 ☔ View full report in Codecov by Sentry. |
hirosassa
approved these changes
Mar 20, 2024
Comment on lines
+377
to
434
| #[test] | ||
| fn test_ignore_image_tags() { | ||
| let diff = " | ||
| @@ -50,7 +48,7 @@ | ||
| - configMapRef: | ||
| name: configmap | ||
| - image: image:latest@sha256:19adf91 | ||
| + image: image:latest | ||
| "; | ||
| let parser = self::DiffParser::new(true, Vec::new()).unwrap(); | ||
| let actual = parser.remove_image_tags(diff, "image"); | ||
| let expected = " | ||
| @@ -50,7 +48,7 @@ | ||
| - configMapRef: | ||
| name: configmap | ||
| "; | ||
| assert_eq!(actual, expected); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_ignore_image_tags_with_no_label() { | ||
| let diff = " | ||
| @@ -50,7 +48,7 @@ | ||
| - configMapRef: | ||
| name: configmap | ||
| - image: image:latest@sha256:19adf91 | ||
| + image: image | ||
| "; | ||
| let parser = self::DiffParser::new(true, Vec::new()).unwrap(); | ||
| let actual = parser.remove_image_tags(diff, "image"); | ||
| let expected = " | ||
| @@ -50,7 +48,7 @@ | ||
| - configMapRef: | ||
| name: configmap | ||
| "; | ||
| assert_eq!(actual, expected); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_donot_ignore_image_tags_when_image_was_changed() { | ||
| let diff = " | ||
| @@ -50,7 +48,7 @@ | ||
| - configMapRef: | ||
| name: configmap | ||
| - image: image:latest | ||
| + image: other:latest | ||
| "; | ||
| let parser = self::DiffParser::new(true, Vec::new()).unwrap(); | ||
| let actual = parser.remove_image_tags(diff, "image"); | ||
| let expected = " | ||
| @@ -50,7 +48,7 @@ | ||
| - configMapRef: | ||
| name: configmap | ||
| - image: image:latest | ||
| + image: other:latest | ||
| "; | ||
| assert_eq!(actual, expected); | ||
| } |
|
@kitagry I'll create new release including this change. Wait a minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33
Sometimes, I want to ignore only tag changes because it is a bit noisy. So, I created the option.